[stable8] fix(NcPasswordField): reset validation on change#8357
Merged
[stable8] fix(NcPasswordField): reset validation on change#8357
Conversation
backportbot
Bot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8357 +/- ##
========================================
Coverage 45.85% 45.85%
========================================
Files 194 194
Lines 4892 4892
Branches 1262 1200 -62
========================================
Hits 2243 2243
- Misses 2561 2563 +2
+ Partials 88 86 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- tests given payload length only Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- do not send a request on empty field Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
backport/8350/stable8
branch
from
3f0b8d8 to
49f10b5
Compare
Antreesy
approved these changes
Mar 25, 2026
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Rewrote logic in NcPasswordField watcher to match main branch behaviour
susnux
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8350
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.